Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Labels:
      None

      Description

      Some problems with Github authentication happen from time to time with the following exception thrown in this case :

      2016.06.20 10:14:22 ERROR web[o.s.s.a.AuthenticationError] Fail to callback authentication with 'github'
      com.github.scribejava.core.exceptions.OAuthException: Response body is incorrect. Can't extract a token from this: 'error=bad_verification_code&error_description=The+code+passed+is+incorrect+or+expired.&error_uri=https%3A%2F%2Fdeveloper.github.com%2Fv3%2Foauth%2F%23bad-verification-code'
              at com.github.scribejava.core.extractors.TokenExtractor20Impl.extract(TokenExtractor20Impl.java:32) ~[na:na]
              at com.github.scribejava.core.oauth.OAuth20ServiceImpl.getAccessToken(OAuth20ServiceImpl.java:37) ~[na:na]
              at org.sonarsource.auth.github.GitHubIdentityProvider.callback(GitHubIdentityProvider.java:111) ~[na:na]
              at org.sonar.server.authentication.OAuth2CallbackFilter.doFilter(OAuth2CallbackFilter.java:71) ~[sonar-server-5.6.jar:na]
      

      After investigation, nothing strange was noticed on the client side with token/headers (but it was not possible to investigate the communication between SonarQube server and Github with a proxy).

      When the problem happens, the authentication is always working with other websites (such as Travis and Grafana) - which tends to indicate that the problem is in the GitHub Auth plugin.

      Looks like the ScribeJava library have recently released fixes for some troubles with Github : https://github.com/scribejava/scribejava/issues/636. Some tests must be done to verified is this would fix the problem.

        Attachments

          Activity

            People

            • Assignee:
              evgeny.mandrikov Evgeny Mandrikov
              Reporter:
              eric.hartmann Eric Hartmann
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved: