Details

      Activity

      Hide
      dinesh.bolkensteyn Dinesh Bolkensteyn added a comment -

      Hi Matthijs,

      Can you confirm that the goal of this ticket is simply to not create a violation on:

      <!DOCTYPE html>   <!-- Compliant -->
      

      Is this the only HTML5 doctype you were thinking about?

      Thank you!

      Show
      dinesh.bolkensteyn Dinesh Bolkensteyn added a comment - Hi Matthijs, Can you confirm that the goal of this ticket is simply to not create a violation on: <!DOCTYPE html> <!-- Compliant --> Is this the only HTML5 doctype you were thinking about? Thank you!
      Hide
      dinesh.bolkensteyn Dinesh Bolkensteyn added a comment - - edited

      In fact I am going to remove this rule altogether:

      We now have a new rule which checks that the document has a DOCTYPE declaration: SONARPLUGINS-2995

      If we remove that part from this rule, then it will only verify that DOCTYPE do have a DTD.

      But if we want to allow HTML5, we must remove that DTD presence requirement.

      Hence, this rule should be removed.

      Show
      dinesh.bolkensteyn Dinesh Bolkensteyn added a comment - - edited In fact I am going to remove this rule altogether: We now have a new rule which checks that the document has a DOCTYPE declaration: SONARPLUGINS-2995 If we remove that part from this rule, then it will only verify that DOCTYPE do have a DTD. But if we want to allow HTML5, we must remove that DTD presence requirement. Hence, this rule should be removed.
      Hide
      dinesh.bolkensteyn Dinesh Bolkensteyn added a comment -

      Done

      Show
      dinesh.bolkensteyn Dinesh Bolkensteyn added a comment - Done
      Hide
      freddy.mallet Freddy Mallet added a comment -

      Manually tested !

      Show
      freddy.mallet Freddy Mallet added a comment - Manually tested !

        People

        • Assignee:
          dinesh.bolkensteyn Dinesh Bolkensteyn
          Reporter:
          matthijs.galesloot Matthijs Galesloot
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: