Uploaded image for project: 'SonarJava'
  1. SonarJava
  2. SONARJAVA-3365

Update the message, title and description of S1607

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4
    • Component/s: Rules

      Description

      Description of rule RSPEC-1607 has been updated to:

      • change its title
      • update the issue message
      • also cover junit5 @Disabled annotation, and not only Junit4 @Ignore  The JUnit5 @Disabled annotation was already supported.
      • update the issue description to include a sentence about the assumeTrue and assumeFalse calls

       

      The current implementation also targets ignoring tests with Assume.assumeFalse(true); , we should check if it makes sense with the current description, and eventually:

      • Remove completely this case. It is not documented anywhere, it could be removed without any trouble.
      • Add a new rule. If it happens that this pattern is actually used, create a rule targeting it.

      The description was updated with a sentence explaining the case of using assumes.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                johann.beleites Johann Beleites
                Reporter:
                michael.gumowski Michael Gumowski
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved: