Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.7
    • Component/s: Web
    • Labels:
      None

      Description

      The property sonar.web.dev has been used to enable the hot reloading of Ruby on Rails extensions. Now it only allows to accept HTTP connections when debugging OAuth plugins that require HTTPS connections in production.

      To keep things simple, the property sonar.web.dev should be dropped and a warning should be logged if OAuth URL is http but not https.

        Activity

        simon.brandhof Simon Brandhof created issue -
        freddy.mallet Freddy Mallet made changes -
        Field Original Value New Value
        Workflow Default Agile SonarSource Workflow V5 [ 207585 ] Default Agile SonarSource Workflow V6 [ 226427 ]
        freddy.mallet Freddy Mallet made changes -
        Workflow Default Agile SonarSource Workflow V6 [ 226427 ] Default Agile SonarSource Workflow V7 [ 255618 ]
        fabrice.bellingard Fabrice Bellingard made changes -
        Fix Version/s 6.6 [ 13961 ]
        Fix Version/s 6.5 [ 13805 ]
        Hide
        gregoire.aubert Gregoire Aubert added a comment -

        Stas Vilchik There is nothing to do on Web side for this ticket right ? It doesn't seem like we are using that property.

        Show
        gregoire.aubert Gregoire Aubert added a comment - Stas Vilchik There is nothing to do on Web side for this ticket right ? It doesn't seem like we are using that property.
        Hide
        stas.vilchik Stas Vilchik added a comment -

        Gregoire Aubert no, it's on the server side.

        Show
        stas.vilchik Stas Vilchik added a comment - Gregoire Aubert no, it's on the server side.
        simon.brandhof Simon Brandhof made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Due Date 11/Oct/17
        Assignee Simon Brandhof [ simon.brandhof ]
        simon.brandhof Simon Brandhof made changes -
        Description The property {{sonar.web.dev}} has been used to enable the hot reloading of Ruby on Rails extensions. Now it only allows to accept HTTP connections when debugging OAuth plugins that require HTTPS connections in production.

        To prevent any misunderstand, the property should be renamed {{sonar.web.oauth.acceptHttp}} and removed from documentation (conf/sonar.properties). A warning must be logged when value is {{true}}.
        The property {{sonar.web.dev}} has been used to enable the hot reloading of Ruby on Rails extensions. Now it only allows to accept HTTP connections when debugging OAuth plugins that require HTTPS connections in production.

        To keep things simple, the property {{sonar.web.dev}} should be dropped and a warning should be logged if OAuth URL is http but not https.
        Show
        simon.brandhof Simon Brandhof added a comment - See https://github.com/SonarSource/sonarqube/pull/2626
        simon.brandhof Simon Brandhof made changes -
        Status In Progress [ 3 ] In Review [ 10002 ]
        simon.brandhof Simon Brandhof made changes -
        Assignee Simon Brandhof [ simon.brandhof ] Teryk Bellahsene [ teryk.bellahsene ]
        simon.brandhof Simon Brandhof made changes -
        Assignee Teryk Bellahsene [ teryk.bellahsene ] Julien Henry [ julien.henry ]
        simon.brandhof Simon Brandhof made changes -
        Assignee Julien Henry [ julien.henry ] Simon Brandhof [ simon.brandhof ]
        simon.brandhof Simon Brandhof made changes -
        Status In Review [ 10002 ] Resolved [ 5 ]
        Assignee Simon Brandhof [ simon.brandhof ] Christophe Levis [ christophe.levis ]
        Resolution Fixed [ 1 ]
        christophe.levis Christophe Levis made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Christophe Levis [ christophe.levis ] Simon Brandhof [ simon.brandhof ]
        simon.brandhof Simon Brandhof made changes -
        Status Reopened [ 4 ] In Review [ 10002 ]
        simon.brandhof Simon Brandhof made changes -
        Status In Review [ 10002 ] Resolved [ 5 ]
        Assignee Simon Brandhof [ simon.brandhof ] Christophe Levis [ christophe.levis ]
        Resolution Fixed [ 1 ]
        christophe.levis Christophe Levis made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Christophe Levis [ christophe.levis ] Simon Brandhof [ simon.brandhof ]
        simon.brandhof Simon Brandhof made changes -
        Fix Version/s 6.7 [ 13972 ]
        Fix Version/s 6.6 [ 13961 ]
        simon.brandhof Simon Brandhof made changes -
        Status Reopened [ 4 ] In Test [ 10302 ]
        Assignee Simon Brandhof [ simon.brandhof ] Christophe Levis [ christophe.levis ]
        Hide
        simon.brandhof Simon Brandhof added a comment - - edited
        Show
        simon.brandhof Simon Brandhof added a comment - - edited Warning is now logged only once at startup if at least one OAuth plugin is installed. https://repox.sonarsource.com/sonarsource-dev/org/sonarsource/sonarqube/sonar-application/6.7.0.32152/sonar-application-6.7.0.32152.zip
        Hide
        julien.lancelot Julien Lancelot added a comment -

        Tested

        Show
        julien.lancelot Julien Lancelot added a comment - Tested
        simon.brandhof Simon Brandhof made changes -
        Status In Test [ 10302 ] Resolved [ 5 ]
        Assignee Christophe Levis [ christophe.levis ] Simon Brandhof [ simon.brandhof ]
        Resolution Fixed [ 1 ]
        simon.brandhof Simon Brandhof made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            simon.brandhof Simon Brandhof
            Reporter:
            simon.brandhof Simon Brandhof
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved: