Uploaded image for project: 'SonarQube'
  1. SonarQube
  2. SONAR-14644

Update Accept header for Github API calls

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.9
    • Component/s: None
    • Edition:
      Community
    • Production Notes:
      None

      Description

      As part of our investigation of existing GitHub API calls from SQ we found out that in order to bring the best LTS ever we really need to update the Accept header that specifies the version of GitHub API that we want to use.

      For two reasons:

      1. We are using the old one, only to be able to access CheckAPI which is already included in the latest GitHub API version.
      2. GitHub recommends that for stability we should be using v3 version. See: https://docs.github.com/en/developers/overview/about-githubs-apis

       

      It goes without saying that after this change we should test the integration with GitHub again (both onboarding and pull request decoration)

        Attachments

          Activity

            People

            Assignee:
            lukasz.jarocki Łukasz Jarocki
            Reporter:
            lukasz.jarocki Łukasz Jarocki
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: