Uploaded image for project: 'SonarQube'
  1. SonarQube
  2. SONAR-12720

Security Hotspots page allows to comment a Security Hotspot

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.2
    • Component/s: Security Hotspots
    • Labels:
      None
    • Edition:
      Community
    • Production Notes:
      None

      Description

      New UI elements

      • see wireframe for UI
      • add input box to provide a comment
        • comment can be provided for all options (fix, safe and just comment)
        • a incentive should be displayed "this stats requires a justification" in the comment box when changing to safe 
      • "Review History" tab
        • the count of comment on the hotspot is displayed in the title (number is hidden if count=0)
        • comments are displayed in the tab, mixed with statuses, ordered by date

      ---------------------------------

      UPDATE 2020-02-12

       

      Make the comment button more visible. Clicking the button opens a comment field in the "Review History" tab. We also keep the "comment" button located in the review history.

      ---------------------------------

      New WS api/hotspots/add_comment

      • internal
      • requires the 'Browse' permission on the specified project
      • parameters
        • hotspot: the hotspot key
        • comment

      Change to WS api/hotspots/change_status

      • add parameter
        • comment (optional)

      Change to WS api/hotspots/show

      • return comments in the response
         to be confirmed
      "comments": [
        {
          "key": "7d7c56f5-7b5a-41b9-87f8-36fa70caa5ba",
          "login": "john.smith",
          "htmlText": "Must be "final"!",
          "markdown": "Must be \"final\"!",
          "updatable": false,
          "createdAt": "2013-05-13T18:08:34+0200"
        }
      ], 

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              sebastien.lesaint Sebastien Lesaint
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: