Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-4787

Encrypting data is security-sensitive

    Details

    • Message:
      Make sure that encrypting data is safe here.
    • Highlighting:
      Hide

      The encryption function call

      Show
      The encryption function call
    • Default Severity:
      Critical
    • Impact:
      High
    • Likelihood:
      Low
    • Default Quality Profiles:
      Sonar way
    • Targeted languages:
      APEX, C, C++, Cobol, Go, Kotlin, Objective-C, Python, Ruby, Rust, Scala, Swift, TypeScript, VB6
    • Covered Languages:
      C#, Java, JavaScript, PHP, VB.Net
    • Analysis Scope:
      Main Sources
    • Common Rule:
      Yes
    • CWE:
      CWE-321,CWE-322,CWE-323,CWE-324,CWE-325,CWE-326,CWE-327,CWE-522
    • OWASP:
      A3,A6
    • SANS Top 25:
      Porous Defenses

      Description

      Encrypting data is security-sensitive. It has led in the past to the following vulnerabilities:

      Proper encryption requires both the encryption algorithm and the key to be strong. Obviously the private key needs to remain secret and be renewed regularly. However these are not the only means to defeat or weaken an encryption.

      This rule flags function calls that initiate encryption/decryption. The goal is to guide security code reviews.

      Ask Yourself Whether

      • the private key might not be random, strong enough or the same key is reused for a long long time.
      • the private key might be compromised. It can happen when it is stored in an unsafe place or when it was transferred in an unsafe manner.
      • the key exchange is made without properly authenticating the receiver.
      • the encryption algorithm is not strong enough for the level of protection required. Note that encryption algorithms strength decreases as time passes.
      • the chosen encryption library is deemed unsafe.
      • a nonce is used, and the same value is reused multiple times, or the nonce is not random.
      • the RSA algorithm is used, and it does not incorporate an Optimal Asymmetric Encryption Padding (OAEP), which might weaken the encryption.
      • the CBC (Cypher Block Chaining) algorithm is used for encryption, and it's IV (Initialization Vector) is not generated using a secure random algorithm, or it is reused.
      • the Advanced Encryption Standard (AES) encryption algorithm is used with an unsecure mode. See the recommended practices for more information.

      You are at risk if you answered yes to any of those questions.

      Recommended Secure Coding Practices

      • Generate encryption keys using secure random algorithms.
      • When generating cryptographic keys (or key pairs), it is important to use a key length that provides enough entropy against brute-force attacks. For the Blowfish algorithm the key should be at least 128 bits long, while for the RSA algorithm it should be at least 2048 bits long.
      • Regenerate the keys regularly.
      • Always store the keys in a safe location and transfer them only over safe channels.
      • If there is an exchange of cryptographic keys, check first the identity of the receiver.
      • Only use strong encryption algorithms. Check regularly that the algorithm is still deemed secure. It is also imperative that they are implemented correctly. Use only encryption libraries which are deemed secure. Do not define your own encryption algorithms as they will most probably have flaws.
      • When a nonce is used, generate it randomly every time.
      • When using the RSA algorithm, incorporate an Optimal Asymmetric Encryption Padding (OAEP).
      • When CBC is used for encryption, the IV must be random and unpredictable. Otherwise it exposes the encrypted value to crypto-analysis attacks like "Chosen-Plaintext Attacks". Thus a secure random algorithm should be used. An IV value should be associated to one and only one encryption cycle, because the IV's purpose is to ensure that the same plaintext encrypted twice will yield two different ciphertexts.
      • The Advanced Encryption Standard (AES) encryption algorithm can be used with various modes. Galois/Counter Mode (GCM) with no padding should be preferred to the following combinations which are not secured:
        • Electronic Codebook (ECB) mode: Under a given key, any given plaintext block always gets encrypted to the same ciphertext block. Thus, it does not hide data patterns well. In some senses, it doesn't provide serious message confidentiality, and it is not recommended for use in cryptographic protocols at all.
        • Cipher Block Chaining (CBC) with PKCS#5 padding (or PKCS#7) is susceptible to padding oracle attacks.

      See

        Attachments

          Issue Links

          1.
          Java RSPEC-4842 Language-Specification Active Unassigned
          2.
          C# RSPEC-4938 Language-Specification Active Unassigned
          3.
          VB.NET RSPEC-5005 Language-Specification Active Unassigned
          4.
          JavaScript RSPEC-5077 Language-Specification Active Unassigned
          5.
          PHP RSPEC-5096 Language-Specification Active Unassigned
          6.
          Python RSPEC-5227 Language-Specification Active Unassigned

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                nicolas.harraudeau Nicolas Harraudeau
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: