Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-4487

Unread "private" fields should be removed

    XMLWordPrintable

    Details

    • Type: Code Smell Detection
    • Status: Active
    • Resolution: Unresolved
    • Labels:
    • Message:
      Remove this unread private field 'xxxx' or refactor the code to use its value.
    • Highlighting:
      • primary: Field name declaration
      • secondary: Statements changing its value
    • Default Severity:
      Critical
    • Impact:
      High
    • Likelihood:
      Low
    • Default Quality Profiles:
      Sonar way
    • Targeted languages:
      C++, Go, Java, Swift, TypeScript
    • Covered Languages:
      C#, Python
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      5min
    • Analysis Level:
      Semantic Analysis
    • Analysis Scope:
      Main Sources, Test Sources
    • Common Rule:
      Yes
    • CERT:
      MSC13-C., MSC56-J.
    • CWE:
      CWE-563

      Description

      Private fields only used to store values without reading them later is a case of dead store. So changing the value of such field is useless and most probably indicates a serious error in the code.

      Noncompliant Code Example

      public class Rectangle {
  private int height;
  private int width;  //width is written but never read

  public Rectangle(int height, int width) {
    this.height=height;
    this.width = width;
  }

  public int getArea() {
    return height * height;
  }
}

      Compliant Solution

      public class Rectangle {
  private int height;
  private int width;

  public Rectangle(int height, int width) {
    this.height=height;
    this.width = width;
  }

  public int getArea() {
    return height * width;
  }
}

      See

        Attachments

          Issue Links

          is implemented by

          Sub-task - The sub-task of the issue SONARPY-811 S4487: Add a message on the secondary location

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-66 Rule S4487: Unread "private" fields should be removed

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARPY-482 Rule S4487: Unread "private" attributes should be removed

          • Major - Major loss of function.
          • Closed

          False-Positive - Unexpected issue reported by a rule SONARPY-636 FP on rule S4487 when an attribute is referenced indirectly

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          relates to

          Code Smell Detection - RSPEC-1144 Unused "private" methods should be removed

          • Active

          Code Smell Detection - RSPEC-1854 Unused assignments should be removed

          • Active

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              freddy.mallet Freddy Mallet (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: