Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-4144 Methods should not have identical implementations
  3. RSPEC-4460

JavaScript: Functions should not have identical implementations

    XMLWordPrintable

    Details

    • Type: Language-Specification
    • Status: Active
    • Resolution: Unresolved
    • Labels:
      None
    • Impact:
      Unknown 'null' severity
    • Likelihood:
      Unknown 'null' severity
    • Default Quality Profiles:
      Sonar way, Sonar way recommended

      Description

      When two functions have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, the code should be refactored.

      Noncompliant Code Example

      function calculateCode() {
        doTheThing();
        doOtherThing();
        return code;
      }
        
      function getName() {  // Noncompliant
        doTheThing();
        doOtherThing();
        return code;
      }
      

      Compliant Solution

      function calculateCode() {
        doTheThing();
        doOtherThing();
        return code;
      }
        
      function getName() {
        return calculateCode();
      }
      

      Exceptions

      Functions with fewer than 3 lines are ignored.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            elena.vilchik Elena Vilchik
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: