Details

    • Type: Language-Specification
    • Status: Active
    • Resolution: Unresolved
    • Labels:
      None
    • Impact:
      Unknown 'null' severity
    • Likelihood:
      Unknown 'null' severity

      Description

      When two methods have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, one implementation should invoke the other.

      Noncompliant Code Example

      private const string CODE = "bounteous";
      private int callCount = 0;
      
      public string GetCode() 
      {
        callCount++;
        return CODE;
      }
      
      public string GetName()  // Noncompliant
      {
        callCount++;
        return CODE;
      }
      

      Compliant Solution

      private const string CODE = "bounteous";
      private int callCount = 0;
      
      public string GetCode() 
      {
        callCount++;
        return CODE;
      }
      
      public string GetName() 
      {
        return GetCode();
      }
      

      Exceptions

      Empty methods, methods with only one line of code and methods with the same name (overload) are ignored.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            amaury.leve Amaury Levé (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: