Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-4144

Methods should not have identical implementations

    XMLWordPrintable

    Details

    • Message:
      Update this method so that its implementation is not identical to "xxx".
    • Highlighting:
      • primary: method signature
      • secondary: original method
        • message: "Original implementation."
    • Default Severity:
      Major
    • Impact:
      Low
    • Likelihood:
      High
    • Default Quality Profiles:
      Sonar way
    • Targeted languages:
      Flex, Rust, Solidity, VB6
    • Covered Languages:
      C#, C, C++, Go, Java, JavaScript, Kotlin, Objective-C, PHP, Python, Ruby, Scala, Swift, TypeScript, VB.Net
    • Irrelevant for Languages:
      ABAP, Cobol, CSS, HTML, PL/I, PL/SQL, RPG, T-SQL, XML
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      15min
    • Analysis Level:
      Syntactic Analysis
    • Analysis Scope:
      Main Sources, Test Sources
    • Common Rule:
      Yes
    • ESLint-SonarJS:
      no-identical-functions

      Description

      When two methods have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, one implementation should invoke the other. Numerical and string literals are not taken into account.

      Noncompliant Code Example

      private final static String CODE = "bounteous";

public String calculateCode() {
  doTheThing();
  return CODE;
}

public String getName() {  // Noncompliant
  doTheThing();
  return CODE;
}

      Compliant Solution

      private final static String CODE = "bounteous";

public String getCode() {
  doTheThing();
  return CODE;
}

public String getName() {
  return getCode();
}

      Exceptions

      Methods that are not accessors (getters and setters), with fewer than 2 statements are ignored.

        Attachments

          Issue Links

          is implemented by

          New Feature - A new feature of the product, which has yet to be developed. SONARFLEX-140 Rule: Methods should not have identical implementations

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARVBSIX-274 Rule: Methods should not have identical implementations

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. CPP-1891 Rule: Methods should not have identical implementations

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARJAVA-2405 Rule S4144: Methods should not have identical implementations

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPHP-715 Rule S4144: Methods should not have identical implementations

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPY-221 Rule S4144: Methods should not have identical implementations

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-2 Rule S4144: Functions should not have identical implementations

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-158 Enable in Ruby rule S4144 (DuplicatedFunctionImplementationCheck)

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-227 [Scala] Enable Rule: S4144 Methods should not have identical implementations

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-314 [Apex] Enable Rule: S4144 Methods should not have identical implementations

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSWIFT-301 Rule: Methods should not have identical implementations

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. SONARSLANG-423 [Go] Enable rules relying on functions

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SONARSLANG-174 S4144 (DuplicatedFunctionImplementationCheck) should not ignore literal values during syntactic equivalence evaluation

          • Major - Major loss of function.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. CPP-2510 S3923: Improve code equivalence checking in case of macro expansion

          • Major - Major loss of function.
          • Open
          links to

          Web Link Is Implemented in SonarC# by #610

          Web Link Is Implemented in SonarJS by #629

          Web Link Is Implemented in SonarTS by #137

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              ann.campbell.2 Ann Campbell
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: