Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-3984

Exceptions should not be created without being thrown

    XMLWordPrintable

    Details

    • Type: Bug Detection
    • Status: Active
    • Resolution: Unresolved
    • Labels:
    • Message:
      Throw this exception or remove this useless statement
    • Highlighting:
      Hide

      The useless statement

      Show
      The useless statement
    • Default Severity:
      Major
    • Impact:
      Low
    • Likelihood:
      High
    • Default Quality Profiles:
      Sonar way
    • Targeted languages:
      C++
    • Covered Languages:
      C#, Java, JavaScript, PHP, Python, TypeScript
    • Irrelevant for Languages:
      Python, Swift, VB.Net
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      2min
    • Analysis Scope:
      Main Sources, Test Sources
    • FindBugs:
      RV_EXCEPTION_NOT_THROWN

      Description

      Creating a new Throwable without actually throwing it is useless and is probably due to a mistake.

      Noncompliant Code Example

      if (x < 0)
  new IllegalArgumentException("x must be nonnegative");

      Compliant Solution

      if (x < 0)
  throw new IllegalArgumentException("x must be nonnegative");

        Attachments

          Issue Links

          is implemented by

          New Feature - A new feature of the product, which has yet to be developed. SONARJAVA-2264 Rule: Exception should not be created without being thrown

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPHP-716 Rule S3984: Exception should not be created without being thrown

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPY-666 Rule S3984: Exceptions should not be created without being raised

          • Major - Major loss of function.
          • Closed

          False Negative - True issue, expected to be covered by a rule, but ultimately not reported SONARPY-795 S3984 should raise an issue when the class hierarchy has multiple levels

          • Major - Major loss of function.
          • Open
          is related to

          Sub-task - The sub-task of the issue SONARJAVA-3958 Add quick fixes for S3984 (UnusedThrowableCheck)

          • Major - Major loss of function.
          • Closed
          relates to

          False-Positive - Unexpected issue reported by a rule SONARPY-617 S3984: Fix FP when wildcard importing redefined builtin

          • Major - Major loss of function.
          • Open
          links to

          Web Link Is Implemented in SonarC# by #251

          Web Link Is Implemented in SonarJS by #633

          Web Link Is Implemented in SonarTS by #153

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              freddy.mallet Freddy Mallet (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: