Non-boolean assignments should not be used as conditions

Using the output of a non-boolean assignment as a condition is highly suspicious. Either it was done accidentally, and the assignment operator = was used in place of the equality operator ==, or it was done with the intent to rely on the automatic conversion of the non-boolean value to a boolean, which could be confusing for maintainers.

See

• MISRA C:2004, 13.1 - Assignment operators shall not be used in expressions that yield a Boolean value