Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-3584

Dynamically allocated memory should be released

    XMLWordPrintable

    Details

    • Message:
      Review the data-flow; this memory allocation might not have been released when reaching exit point at line {{line}}.
    • Highlighting:
      • Primary: the allocation call - [m|c|re]alloc|new
      • Additional: statement exiting the function
        • Message: Exit point
    • Default Severity:
      Blocker
    • Impact:
      High
    • Likelihood:
      High
    • Default Quality Profiles:
      Sonar way, MISRA C++ 2008 recommended
    • Covered Languages:
      C, C++, Objective-C
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      20min
    • CERT:
      MEM31-C.
    • CWE:
      CWE-401

      Description

      Memory allocated dynamically with calloc(...), malloc(...), realloc(...) or new should be released when it's not needed anymore. Failure to do so will result in a memory leak that could bring the box to its knees.

      This rule raises an issue when memory is allocated and not freed in the same function. Allocated memory is ignored if a pointer to it is {{return}}ed to the caller or stored in a structure that's external to the function.

      Noncompliant Code Example

      int fun() {
  char* name = (char *) malloc (size);
  if (!name) {
    return 1;
  }
  // ...
  return 0; // Noncompliant, memory pointed by "name" has not been released
}

      Compliant Solution

      int fun() {
  char* name = (char *) malloc (size);
  if (!name) {
    return 1;
  }
  // ...
  free(name);
  return 0;
}

      See

      • MITRE, CWE-401 - Improper Release of Memory Before Removing Last Reference ('Memory Leak')
      • MEM00-C. - Allocate and free memory in the same module, at the same level of abstraction
      • CERT, MEM31-C. - Free dynamically allocated memory when no longer needed

        Attachments

          Issue Links

          is implemented by

          New Feature - A new feature of the product, which has yet to be developed. CPP-884 C Rule: Dynamically allocated memory should be released

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. CPP-1671 C++ Rule: Dynamically allocated memory should be released (S3584)

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. CPP-2312 Add 12 rules for Objective-C based on symbolic execution

          • Major - Major loss of function.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. CPP-1843 S3584, S2095: Swap primary & secondary locations

          • Major - Major loss of function.
          • Closed

          False-Positive - Unexpected issue reported by a rule CPP-2558 S3584: Fix false-positives when memory is released in undefined function

          • Major - Major loss of function.
          • Open

          False-Positive - Unexpected issue reported by a rule CPP-2823 S3584: fix FP with make_unique and VS2017

          • Major - Major loss of function.
          • Closed

          False-Positive - Unexpected issue reported by a rule CPP-3087 S3584: Fix false-positive on parenthesized "(make_unique)" call

          • Major - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              massimo.paladin Massimo PALADIN
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: