Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-134 Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply
  3. RSPEC-3534

C#: Control flow statements "if", "switch", "for", "foreach", "while", "do" and "try" should not be nested too deeply

    Details

    • Type: Language-Specification
    • Status: Active
    • Resolution: Unresolved
    • Labels:
      None
    • Impact:
      Unknown 'null' severity
    • Likelihood:
      Unknown 'null' severity

      Description

      Nested if, switch, for, foreach, while, do, and try statements are key ingredients for making what's known as "Spaghetti code".
      Such code is hard to read, refactor and therefore maintain.

      Noncompliant Code Example

      With the default threshold of 3:

      if (condition1) // Compliant - depth = 1
      {                  
        /* ... */
        if (condition2) // Compliant - depth = 2
        {                
          /* ... */
          for(int i = 0; i < 10; i++) // Compliant - depth = 3, not exceeding the limit
          {  
            /* ... */
            if (condition4) // Noncompliant - depth = 4
            {            
              if (condition5) // Depth = 5, exceeding the limit, but issues are only reported on depth = 4
              {          
                /* ... */
              }
              return;
            }
          }
        }
      }
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              tamas.vajk Tamas Vajk (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: