Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-3358

Ternary operators should not be nested

    Details

    • Type: Code Smell Detection
    • Status: Active
    • Resolution: Unresolved
    • Labels:
    • Message:
      Extract this nested ternary operation into an independent statement.
    • Highlighting:
      Hide

      Primary: highlight the entire nested ternary operation

      Show
      Primary: highlight the entire nested ternary operation
    • Default Severity:
      Major
    • Impact:
      Low
    • Likelihood:
      High
    • Default Quality Profiles:
      Sonar way
    • Targeted languages:
      ABAP, APEX, Flex, PL/SQL, Rust, Scala, T-SQL, TypeScript
    • Covered Languages:
      C#, C, C++, Java, JavaScript, Objective-C, PHP, Python, Swift, VB.Net
    • Irrelevant for Languages:
      Cobol, Go, HTML, Kotlin, PL/I, RPG, Ruby, VB6, XML
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      5min
    • Analysis Level:
      Syntactic Analysis
    • Analysis Scope:
      Main Sources, Test Sources
    • Common Rule:
      Yes
    • ESLint:
      no-nested-ternary

      Description

      Just because you can do something, doesn't mean you should, and that's the case with nested ternary operations. Nesting ternary operators results in the kind of code that may seem clear as day when you write it, but six months later will leave maintainers (or worse - future you) scratching their heads and cursing.

      Instead, err on the side of clarity, and use another line to express the nested operation as a separate statement.

      Noncompliant Code Example

      public String getReadableStatus(Job j) {
  return j.isRunning() ? "Running" : j.hasErrors() ? "Failed" : "Succeeded";  // Noncompliant
}

      Compliant Solution

      public String getReadableStatus(Job j) {
  if (j.isRunning()) {
    return "Running";
  }
  return j.hasErrors() ? "Failed" : "Succeeded";
}

        Attachments

          Issue Links

          is implemented by

          Sub-task - The sub-task of the issue SONARPY-806 S3358: Add a message on the secondary location

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARABAP-361 Rule: Ternary operators should not be nested

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARFLEX-132 Rule: Ternary operators should not be nested

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARPLSQL-684 Rule: Ternary operators should not be nested

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARTSQL-116 Rule: Ternary operators should not be nested

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. CPP-1645 Rule: Conditional operators should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARJAVA-2068 S3358 Ternary operators should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPHP-747 Rule S3358: Ternary operators should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPY-252 Rule S3358: Conditional expressions should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSWIFT-346 Rule: Ternary operators should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARVBSIX-267 Rule: Ternary operators should not be nested

          • Major - Major loss of function.
          • Closed
          relates to

          False-Positive - Unexpected issue reported by a rule SONARPHP-1115 Revise rule S3358 to exclude shorthand ternary operator

          • Major - Major loss of function.
          • Closed

          Code Smell Detection - RSPEC-134 Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply

          • Active
          links to

          Web Link C#

          Web Link TS: Ternary operators should not be nested

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                nicolas.peru Nicolas Peru
              • Votes:
                2 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: