Details

    • Type: Language-Specification
    • Status: Active
    • Resolution: Unresolved
    • Labels:
      None
    • Impact:
      Unknown 'null' severity
    • Likelihood:
      Unknown 'null' severity

      Description

      Using the same value on either side of a binary operator is almost always a mistake. In the case of logical operators, it is either a copy/paste error and therefore a bug, or it is simply wasted code, and should be simplified. In the case of bitwise operators and most binary mathematical operators, having the same value on both sides of an operator yields predictable results, and should be simplified.

      Noncompliant Code Example

           C                   IF        X = X
      
            /free
              if a = a; // always true
                doZ();
              endif;
              if a <> a; // always false
                doY();
              endif;
              if a = b and a = b; // if the first one is true, the second one is too
                doX();
              endif;
              if a = b or a = b; // if the first one is true, the second one is too
                doV();
              endif;
              
              j = 5 / 5; //always 1
              k = 5 - 5; //always 0
            /end-free
      

      Exceptions

      This rule ignores * and +.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              pierre-yves.nicolas Pierre-Yves Nicolas
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: