Details

    • Type: Language-Specification
    • Status: Active
    • Resolution: Unresolved
    • Labels:
      None
    • Message:
      Hide
      - Correct one of the identical expressions on both sides of operator '{0}'.
      - Change one instance of '{0}' to a different value; comparing '{0}' to itself always returns true.
      Show
      - Correct one of the identical expressions on both sides of operator '{0}'. - Change one instance of '{0}' to a different value; comparing '{0}' to itself always returns true.
    • Impact:
      Unknown 'null' severity
    • Likelihood:
      Unknown 'null' severity

      Description

      Using the same value on either side of a binary operator is almost always a mistake. In the case of logical operators, it is either a copy/paste error and therefore a bug, or it is simply wasted code, and should be simplified. In the case of bitwise operators and most binary mathematical operators, having the same value on both sides of an operator yields predictable results, and should be simplified.

      Noncompliant Code Example

      if ( a == a ) // always true
      { 
        doZ();
      }
      if ( a != a ) // always false
      {
        doY();
      }
      if ( a == b && a == b ) // if the first one is true, the second one is too
      { 
        doX();
      }
      if ( a == b || a == b ) // if the first one is true, the second one is too
      { 
        doW();
      }
      
      int j = 5 / 5; //always 1
      int k = 5 - 5; // always 0
      
      c.Equals(c);    //always true
      Object.Equals(c, c); //always true
      

      Exceptions

      This rule ignores *, +, =, <<, and >>.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              tamas.vajk Tamas Vajk (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: