Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-1862 Related "if/else if" statements should not have the same condition
  3. RSPEC-2628

Swift: Related "if/else if" statements and "cases" in a "switch" should not have the same condition

    Details

    • Type: Language-Specification
    • Status: Active
    • Resolution: Unresolved
    • Labels:
      None
    • Impact:
      Unknown 'null' severity
    • Likelihood:
      Unknown 'null' severity

      Description

      A switch and a chain of if/else if statements is evaluated from top to bottom. At most, only one branch will be executed: the first one with a condition that evaluates to true.

      Therefore, duplicating a condition automatically leads to dead code. Usually, this is due to a copy/paste error. At best, it's simply dead code and at worst, it's a bug that is likely to induce further bugs as the code is maintained, and obviously it could lead to unexpected behavior.

      Noncompliant Code Example

      if param == 1 {
        openWindow()
      } else if param == 2 {
        closeWindow()
      } else if param == 1 {            // Noncompliant
        moveWindowToTheBackground()
      }
      
      switch i {
        case 1:
          //...
        case 3:
          //...
        case 1:                         // Noncompliant
          //...
        default:
          // ...
      }
      

      Compliant Solution

      if param == 1 {
        openWindow()
      } else if param == 2 {
        closeWindow()
      } else if param == 3 {
        moveWindowToTheBackground()
      }
      
      switch i {
        case 1:
          //...
        case 3:
          //...
        default:
          // ...
      }
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              elena.vilchik Elena Vilchik
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: