Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-1185 Overriding methods should do more than simply call the same method in the super class
  3. RSPEC-1993

PHP

    XMLWordPrintable

    Details

    • Type: Language-Specification
    • Status: Active
    • Resolution: Unresolved
    • Labels:
      None
    • Impact:
      Unknown 'null' severity
    • Likelihood:
      Unknown 'null' severity

      Description

      Noncompliant Code Example

      class Child extends Parent {

  public function func($n,$m) {
    parent::func($n$m);  // Noncompliant
  }
}

class Parent {
  public function func($n, $m) {
    // do something
  }
}

      Compliant Solution

      class Child extends Parent {

  public function func($n,$m) {
    parent::func($n$m);  
    // do additional things...
  }
}

class Parent {
  public function func($n, $m) {
    // do something
  }
}

      or

      class Child extends Parent {
  // function eliminated
}

class Parent {
  public function func($n, $m) {
    // do something
  }
}

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            ann.campbell.2 Ann Campbell
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: