Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-1821

"switch" statements should not be nested

    Details

    • Type: Code Smell Detection
    • Status: Active
    • Resolution: Unresolved
    • Labels:
    • Message:
      Refactor the code to eliminate this nested "switch".
    • Default Severity:
      Critical
    • Impact:
      High
    • Likelihood:
      Low
    • Targeted languages:
      ABAP, Cobol, PL/I, RPG
    • Covered Languages:
      C#, C, C++, Flex, Go, Java, JavaScript, Kotlin, Objective-C, PHP, Ruby, Scala, Swift, TypeScript, VB.Net, VB6
    • Irrelevant for Languages:
      HTML, PL/SQL, Python, T-SQL, XML
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      10min
    • Analysis Level:
      Syntactic Analysis
    • Analysis Scope:
      Main Sources, Test Sources
    • Common Rule:
      Yes
    • TSLint-SonarTS:
      no-nested-switch

      Description

      Nested switch structures are difficult to understand because you can easily confuse the cases of an inner switch as belonging to an outer statement. Therefore nested switch statements should be avoided.

      Specifically, you should structure your code to avoid the need for nested switch statements, but if you cannot, then consider moving the inner switch to another function.

        Attachments

          Issue Links

          is implemented by

          New Feature - A new feature of the product, which has yet to be developed. SONARABAP-356 Rule: "switch" statements should not be nested

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARCOBOL-1498 Rule: "switch" statements should not be nested

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARPLI-178 Rule: "switch" statements should not be nested

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARRPG-174 Rule: "switch" statements should not be nested

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. CPP-811 Rule: "switch" statements should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARJAVA-2649 Rule S1821: "switch" statements should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPHP-774 Rule: "switch" statements should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-8 Rule S1821: "switch" statements should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-208 [Scala] Enable Rule: S1821 "match" statements should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-283 [Apex] Enable Rule: S1821 "switch" statements should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSWIFT-64 Rule: "switch" statements should not be nested

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARVBSIX-258 Rule: "switch" statements should not be nested

          • Major - Major loss of function.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SONARJAVA-3744 Extend existing rules to support Switch Expression

          • Major - Major loss of function.
          • Closed
          relates to

          Code Smell Detection - RSPEC-134 Control flow statements "if", "for", "while", "switch" and "try" should not be nested too deeply

          • Active
          links to

          Web Link Implemented by https://jira.codehaus.org/browse/SONARFLEX-17

          Web Link Is implemented by sonar-csharp/issues/1184

          Web Link Is implemented by SonarJS/issues/949

          Web Link Is implemented by SonarTS/issues/534

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ann.campbell.2 Ann Campbell
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: