Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-1764

Identical expressions should not be used on both sides of a binary operator

    Details

    • Type: Bug Detection
    • Status: Active
    • Resolution: Unresolved
    • Labels:
    • Message:
      Hide
      - Correct one of the identical sub-expressions on both sides of operator "XXX".
      - Correct one of the identical sub-expressions on both sides of equals.
      - Correct one of the identical argument sub-expressions.
      Show
      - Correct one of the identical sub-expressions on both sides of operator "XXX". - Correct one of the identical sub-expressions on both sides of equals. - Correct one of the identical argument sub-expressions.
    • Highlighting:
      • primary location: right operand
      • secondary location: equivalent left operand
        • message: "Identical sub-expression."
    • Default Severity:
      Major
    • Impact:
      Low
    • Likelihood:
      High
    • Default Quality Profiles:
      Sonar way
    • Targeted languages:
      Flex, PL/I, VB6
    • Covered Languages:
      ABAP, C#, C, C++, Cobol, Go, Java, JavaScript, Kotlin, Objective-C, PHP, PL/SQL, Python, RPG, Ruby, Scala, Swift, T-SQL, TypeScript, VB.Net
    • Irrelevant for Languages:
      HTML, XML
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      2min
    • Analysis Level:
      Syntactic Analysis
    • Analysis Scope:
      Main Sources, Test Sources
    • Common Rule:
      Yes
    • CERT:
      MSC12-C.
    • CPPCheck:
      comparisonFunctionIsAlwaysTrueOrFalse, duplicateExpression
    • ESLint:
      no-self-compare
    • ESLint-SonarJS:
      no-identical-expressions
    • FindBugs:
      SA_FIELD_SELF_COMPARISON, SA_LOCAL_SELF_COMPARISON, SA_FIELD_SELF_COMPUTATION, SA_LOCAL_SELF_COMPUTATION,RpC_REPEATED_CONDITIONAL_TEST
    • ReSharper:
      EqualExpressionComparison
    • TSLint-SonarTS:
      no-identical-expressions

      Description

      Using the same value on either side of a binary operator is almost always a mistake. In the case of logical operators, it is either a copy/paste error and therefore a bug, or it is simply wasted code, and should be simplified. In the case of bitwise operators and most binary mathematical operators, having the same value on both sides of an operator yields predictable results, and should be simplified.

      Exceptions

      This rule ignores *, +, and =.

      See

      • CERT, MSC12-C. - Detect and remove code that has no effect or is never executed
      • S1656 - Implements a check on =.

        Attachments

          Issue Links

          contributes to

          MMF - Minimum Marketable Feature MMF-887 First pack of Typescript rules available as a TSLint extension

          • Major - Major loss of function.
          • Closed
          is implemented by

          New Feature - A new feature of the product, which has yet to be developed. SONARFLEX-120 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARPLI-177 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARVBSIX-257 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. CPP-612 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARCOBOL-1190 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPLSQL-609 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPY-141 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARRPG-119 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-146 Enable in Ruby rule S1764 (IdenticalBinaryOperandCheck)

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-215 [Scala] Enable Rule: S1764 Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-284 [Apex] Enable Rule: S1764 Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-415 [Go] Enable rules relying on Binary and Unary Expression, including two new rules (S1940, S1067)

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSWIFT-59 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARTSQL-12 Rule: Identical expressions should not be used on both sides of a binary operator

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. CPP-707 Create Objective-C rules repository containing targeted rules

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. CPP-2732 S1764: Add a message on secondary locations

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SONARJAVA-3584 S1764: Add a message on secondary locations

          • Major - Major loss of function.
          • Closed

          False-Positive - Unexpected issue reported by a rule SONARPY-796 S1764 raises an issue when "!=" or "==" is used to check if a value is "nan".

          • Major - Major loss of function.
          • Open
          is related to

          Language-Specification - Type used to overload a rule specification for a language RSPEC-4450 Java: "Double.isNaN" or "Float.isNaN" should be used

          • Active

          Task - A task that needs to be done. SONARCOBOL-1411 Leverage commutative operators in IdenticalOperandsInBinaryExpressionCheck

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. CPP-2365 Improve S1764: non-const function should be an exception

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. CPP-2510 S3923: Improve code equivalence checking in case of macro expansion

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. CPP-2951 S1764: Add support for <=>

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. CPP-3048 S1764: Add support for rewritten "operator!="

          • Major - Major loss of function.
          • Closed

          MMF - Minimum Marketable Feature MMF-878 Java: New rules

          • Major - Major loss of function.
          • Closed

          False-Positive - Unexpected issue reported by a rule SONARPY-785 Fix FP on S1764 for expressions in try/except blocks

          • Major - Major loss of function.
          • Closed

          Code Smell Detection - RSPEC-2589 Boolean expressions should not be gratuitous

          • Active
          links to

          Web Link Is Implemented in SonarTS by #7

          1.
          		 Java RSPEC-2079 Language-Specification Active Unassigned
          2.
          		 C-Family RSPEC-2080 Language-Specification Active Unassigned
          3.
          		 COBOL RSPEC-2584 Language-Specification Active Unassigned
          4.
          		 JavaScript RSPEC-2686 Language-Specification Active Unassigned
          5.
          		 C# RSPEC-2739 Language-Specification Active Unassigned
          6.
          		 PHP RSPEC-2839 Language-Specification Active Unassigned
          7.
          		 RPG RSPEC-2917 Language-Specification Active Unassigned
          8.
          		 Swift RSPEC-3088 Language-Specification Active Unassigned
          9.
          		 VB.NET RSPEC-3712 Language-Specification Active Unassigned
          10.
          		 Python RSPEC-3820 Language-Specification Active Unassigned
          11.
          		 T-SQL RSPEC-4090 Language-Specification Active Unassigned
          12.
          		 PL/SQL RSPEC-4229 Language-Specification Active Unassigned
          13.
          		 Go RSPEC-4514 Language-Specification Active Unassigned
          14.
          		 Apex RSPEC-4979 Language-Specification Active Unassigned

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ann.campbell.2 Ann Campbell
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: