Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-1763

All code should be reachable

    Details

    • Type: Bug Detection
    • Status: Active
    • Resolution: Unresolved
    • Labels:
    • Message:
      Refactor this piece of code to not have any dead code after this "[return|break|continue|goto|throw|switch]".
    • Highlighting:
      • primary: the jump statement, or the switch statement
      • secondary: the unreachable code after the jump
    • Default Severity:
      Major
    • Impact:
      Low
    • Likelihood:
      High
    • Default Quality Profiles:
      Sonar way
    • Legacy Key:
      UnreachableCode, DeadCodeCheck
    • Targeted languages:
      ABAP, Cobol, Flex, PL/I, RPG, Rust, VB.Net, VB6
    • Covered Languages:
      C, C++, Go, JavaScript, Kotlin, Objective-C, PHP, PL/SQL, Python, Ruby, Scala, Swift, T-SQL
    • Irrelevant for Languages:
      C#, Java, TypeScript
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      5min
    • Analysis Level:
      Syntactic Analysis
    • Analysis Scope:
      Main Sources, Test Sources
    • Common Rule:
      Yes
    • CERT:
      MSC12-C., MSC56-J.
    • CWE:
      CWE-561
    • CPPCheck:
      duplicateBreak,unreachableCode
    • ESLint:
      no-unreachable
    • PVS-Studio:
      V612

      Description

      Some statements (return, break, continue, goto, switch) and throw expressions move control flow out of the current code block. So any unlabeled statements that come after such a jump are unreachable, and either this dead code should be removed, or the logic should be corrected.

      Noncompliant Code Example

      int fun(int a) {
  int i = 10;
  return i + a;       // Noncompliant 
  i++;             // dead code
}

      Compliant Solution

      int fun(int a) {
  int i = 10;
  return i + a;
}

      See

        Attachments

          Issue Links

          deprecates

          Finding Detection - RSPEC-1538 Unreachable code

          • Closed
          is duplicated by

          Bug Detection - RSPEC-894 There should not be unreachable code

          • Closed

          Code Smell Detection - RSPEC-901 Dead code should be removed

          • Closed
          is implemented by

          New Feature - A new feature of the product, which has yet to be developed. CPP-614 Rule: Jump statements should not be followed by other statements

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-61 Rule: Jump statements should not be followed by dead code

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-143 Enable in Ruby rule S1763 (CodeAfterJumpCheck)

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-226 [Scala] Enable Rule: S1763 Jump statements should not be followed by dead code

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSLANG-315 [Apex] Enable Rule: S1763 Jump statements should not be followed by dead code

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSWIFT-65 Rule: Jump statements should not be followed by other statements

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARTSQL-29 Rule: Jump statements should not be followed by other statements

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. CPP-707 Create Objective-C rules repository containing targeted rules

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. SONARSLANG-429 [Go] Enable rule S1763: RSPEC- Jump statements should not be followed by dead code

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SONARTSQL-121 Update rule "Jump statements should not be followed by other statements" to be based on CFG

          • Major - Major loss of function.
          • Closed

          False-Positive - Unexpected issue reported by a rule SONARSLANG-447 [Go] - FP on S1763 when a semicolon is added

          • Major - Major loss of function.
          • Open

          False-Positive - Unexpected issue reported by a rule SONARSLANG-448 [Go] - FP on S1763 when jumps are followed by labelled code

          • Major - Major loss of function.
          • Open
          relates to

          False-Positive - Unexpected issue reported by a rule SONARSLANG-439 [Go] S1763 FP on function with label

          • Major - Major loss of function.
          • Open

          Code Smell Detection - RSPEC-902 Unused functions and methods should be removed

          • Closed

          Code Smell Detection - RSPEC-897 Unused type declarations should be removed

          • Active

          Bug Detection - RSPEC-905 Non-empty statements should change control flow or have at least one side-effect

          • Active

          Code Smell Detection - RSPEC-1029 Class templates, function templates, class template member functions and class template static members should be instantiated at least once

          • Active

          Code Smell Detection - RSPEC-1116 Empty statements should be removed

          • Active

          Code Smell Detection - RSPEC-1172 Unused function parameters should be removed

          • Active

          Bug Detection - RSPEC-1751 Loops with at most one iteration should be refactored

          • Active

          Code Smell Detection - RSPEC-1854 Unused assignments should be removed

          • Active

          Bug Detection - RSPEC-1862 Related "if/else if" statements should not have the same condition

          • Active

          Code Smell Detection - RSPEC-1879 Unused macros should be removed

          • Active

          Bug Detection - RSPEC-1475 "STOP RUN" or "GOBACK" should be the last statement of a sequence

          • Active
          links to

          Web Link Implemented by SONARJS-270

          Web Link Implemented SONARPHP-368

          Web Link is implemented by sonar-go/issues/96

          1.
          		 PHP RSPEC-2013 Language-Specification Active Unassigned
          2.
          		 PL/SQL RSPEC-2395 Language-Specification Active Unassigned
          3.
          		 Swift RSPEC-2478 Language-Specification Active Unassigned
          4.
          		 JavaScript RSPEC-2745 Language-Specification Active Unassigned
          5.
          		 Python RSPEC-2775 Language-Specification Active Unassigned
          6.
          		 T-SQL RSPEC-4106 Language-Specification Active Unassigned
          7.
          		 Go RSPEC-4565 Language-Specification Active Unassigned
          8.
          		 Kotlin RSPEC-4712 Language-Specification Active Unassigned
          9.
          		 Ruby RSPEC-4779 Language-Specification Active Unassigned
          10.
          		 Scala RSPEC-4942 Language-Specification Active Unassigned
          11.
          		 Apex RSPEC-5007 Language-Specification Active Unassigned
          12.
          		 C-Family RSPEC-5368 Language-Specification Active Unassigned

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ann.campbell.2 Ann Campbell
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: