Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-1617

Error handling should be defined in F specs

    XMLWordPrintable

    Details

    • Type: Code Smell Detection
    • Status: Active
    • Resolution: Unresolved
    • Labels:
    • Message:
      Add the error handling "INFSR(xxxx)" keyword to this F spec
    • List of parameters:
      Hide

      key: format_error_handling
      description: Regular expression describing the names of valid error handling routines
      default value: ^*PSSR$

      Show
      key: format_error_handling description: Regular expression describing the names of valid error handling routines default value: ^*PSSR$
    • Default Severity:
      Critical
    • Impact:
      High
    • Likelihood:
      Low
    • Default Quality Profiles:
      Sonar way
    • Covered Languages:
      RPG
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      5min

      Description

      Error handling should be defined on file operations to ensure correct processing of program failures rather than defaulting to an abnormal program end. This rule checks two things:

      • INFSR error handling is defined on file operations.
      • error handling is delegated to an appropriately named routine.

      Noncompliant Code Example

      Given the default parameter value, ^*PSSR$:

           F* Noncompliant
     FIPBDCCP   IF   E           K DISK

     FEP210     CF   E             WORKSTN
     F                                     SFILE(EP21003S:RELN03)     
     
     FEP471R1   O    E             PRINTER 
     F                                     USROPN
     F                                     INFDS(W1SF01)

      Compliant Solution

           FIPBDCCP   IF   E           K DISK    INFSR(*PSSR)

     FEP210     CF   E             WORKSTN INFSR(*PSSR)
     F                                     SFILE(EP21003S:RELN03)
    
     FEP471R1   O    E             PRINTER INFSR(*PSSR)
     F                                     USROPN
     F                                     INFDS(W1SF01)

        Attachments

          Issue Links

          is implemented by

          New Feature - A new feature of the product, which has yet to be developed. SONARRPG-30 Rule: "INFSR(*PSSR)" should be defined in in F spec

          • Major - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              freddy.mallet Freddy Mallet (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: