Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-1301

"switch" statements should have at least 3 "case" clauses

    Details

    • Type: Code Smell Detection
    • Status: Active
    • Resolution: Unresolved
    • Labels:
    • Message:
      Replace this ["switch"|"CASE"|"Select Case"] statement with ["if"|"IF"|"If"] statements to increase readability.
    • Default Severity:
      Minor
    • Impact:
      Low
    • Likelihood:
      Low
    • Default Quality Profiles:
      Sonar way
    • Targeted languages:
      Cobol, PL/I, RPG
    • Covered Languages:
      ABAP, C#, C, C++, Flex, Java, JavaScript, Objective-C, PHP, Swift, TypeScript, VB.Net, VB6
    • Irrelevant for Languages:
      Go, HTML, PL/SQL, Python, T-SQL, XML
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      5min
    • Analysis Level:
      Syntactic Analysis
    • Analysis Scope:
      Main Sources, Test Sources
    • Common Rule:
      Yes
    • ESLint-SonarJS:
      no-small-switch
    • PC-Lint:
      764, 1764, 483, 1483
    • PMD:
      TooFewBranchesForASwitchStatement
    • TSLint-SonarTS:
      no-small-switch

      Description

      switch statements are useful when there are many different cases depending on the value of the same expression.
      For just one or two cases however, the code will be more readable with if statements.

      Noncompliant Code Example

      switch (variable) {
  case 0:
    doSomething();
    break;
  default:
    doSomethingElse();
    break;
}

      Compliant Solution

      if (variable == 0) {
  doSomething();
} else {
  doSomethingElse();
}

        Attachments

          Issue Links

          deprecates

          Finding Detection - RSPEC-921 Each switch statement should have at least one "case"

          • Closed
          is implemented by

          New Feature - A new feature of the product, which has yet to be developed. SONARCOBOL-1494 Rule: "switch" statements should have at least 3 "case" clauses

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARPLI-171 Rule: "switch" statements should have at least 3 "case" clauses

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SONARRPG-169 Rule: "switch" statements should have at least 3 "case" clauses

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. CPP-604 Rule: switch statements should have at least 3 case clauses

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARABAP-232 Rule: ["switch"|"CASE"] statements should have at least 3 ["case"|"WHEN"] clauses

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARSWIFT-66 Rule: "switch" statements should have at least 3 "case" clauses

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARVB-287 Rule S1301: "switch" statements should have at least 3 "case" clauses

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARVBSIX-168 Rule: ["switch"|"CASE"|"Select Case"] statements should have at least 3 ["case"|"WHEN"|"Case"] clauses

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARVBSIX-250 Rule: "switch" statements should have at least 3 "case" clauses

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. CPP-707 Create Objective-C rules repository containing targeted rules

          • Major - Major loss of function.
          • Closed
          is related to

          False-Positive - Unexpected issue reported by a rule CPP-2437 S1301: Fix false-positives by reducing the number of catch to 2

          • Major - Major loss of function.
          • Closed

          Code Smell Detection - RSPEC-920 Switch statement conditions should not have essentially boolean type

          • Active

          Code Smell Detection - RSPEC-5309 Every switch statement shall have at least one case-clause

          • Active
          links to

          Web Link Is implemented by SonarTS/issues/520

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                freddy.mallet Freddy Mallet (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: