Uploaded image for project: 'Rules Repository'
  1. Rules Repository
  2. RSPEC-1185

Overriding methods should do more than simply call the same method in the super class

    XMLWordPrintable

    Details

    • Type: Code Smell Detection
    • Status: Active
    • Resolution: Unresolved
    • Labels:
    • Message:
      Remove this method "XXXX" to simply inherit it.
    • Default Severity:
      Minor
    • Impact:
      Low
    • Likelihood:
      Low
    • Default Quality Profiles:
      Sonar way
    • Targeted languages:
      Swift
    • Covered Languages:
      C#, C, C++, Flex, Java, PHP
    • Remediation Function:
      Constant/Issue
    • Constant Cost:
      2min
    • Analysis Scope:
      Main Sources, Test Sources
    • Implementation details:
    • FindBugs:
      FI_USELESS, USM_USELESS_SUBCLASS_METHOD
    • PMD:
      FinalizeOnlyCallsSuperFinalize, UselessOverridingMethod
    • ReSharper:
      RedundantOverridenMember
    • Quick-fixes:
      Hide

      Remove redundant override

      Show
      Remove redundant override

      Description

      Overriding a method just to call the same method from the super class without performing any other actions is useless and misleading. The only time this is justified is in final overriding methods, where the effect is to lock in the parent class behavior. This rule ignores such overrides of equals, hashCode and toString.

        Attachments

          Issue Links

          is implemented by

          New Feature - A new feature of the product, which has yet to be developed. CPP-1546 C++ Rule: Overriding methods should do more than simply call the same method in the super class

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SONARPHP-347 Rule: Overriding methods should do more than simply call the same method in the super class

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SONARFLEX-57 S1185: Add exception for final methods

          • Major - Major loss of function.
          • Open
          is related to

          Bug - A problem which impairs or prevents the functions of the product. SONARJAVA-1347 FP on S1185: Changing method visibility should not raise issue

          • Major - Major loss of function.
          • Closed

          False-Positive - Unexpected issue reported by a rule CPP-2418 S1185: Fix false-positives with "final"

          • Major - Major loss of function.
          • Closed

          False-Positive - Unexpected issue reported by a rule SONARJAVA-3612 FP in S1185 when class is annotated "@Transactional"

          • Major - Major loss of function.
          • Closed

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              freddy.mallet Freddy Mallet (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: